fix(integrations): show disabled role combobox for readonly members#3921
fix(integrations): show disabled role combobox for readonly members#3921waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The role selector JSX is deduplicated into a single Reviewed by Cursor Bugbot for commit 768eda9. Configure here. |
Greptile SummaryThis PR fixes a visual inconsistency in the integrations members table where readonly (non-admin) users saw an unstyled
Confidence Score: 5/5Safe to merge — the change is a targeted UI fix with no risk of data mutation for readonly users. All findings are P2 or lower. The core logic is correct: the disabled expression exactly mirrors the previous per-branch logic, the grid layout is preserved, and onChange cannot fire on a disabled Combobox. No tests were added but the change is purely presentational. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Render member row] --> B{isSelectedAdmin?}
B -- Yes --> C[Combobox: disabled if sole admin]
B -- No --> D[Combobox: always disabled]
C --> E{isSelectedAdmin?}
D --> E
E -- Yes --> F[Remove Button]
E -- No --> G[empty div]
Reviews (1): Last reviewed commit: "fix(integrations): show disabled role co..." | Re-trigger Greptile |
Summary
Type of Change
Testing
Tested manually
Checklist